ISSUE-009 - Alternative useDimensions added.

Turns out... they're not as reliable. In testing I had the menu's height regularly fail to provide its height data.
This commit is contained in:
Kyle Geib committed 2022-01-13 16:21:23 -05:00
1 parent aba5cc20be
commit 7999f15c20
3 files changed
+83 -7

No files matched your search

+45 -1
View File
@@ -1,4 +1,5 @@
import React, { useEffect, useRef, useState } from "react";
import useResizeObserver from "@react-hook/resize-observer";
import React, { useEffect, useLayoutEffect, useRef, useState } from "react";
import ResizeObserver from "resize-observer-polyfill";
export const useDimensions = <T extends HTMLElement>() => {
@@ -32,3 +33,46 @@ export const useDimensions = <T extends HTMLElement>() => {
{ height: number, width: number },
];
};
/**
* Proven to be less reliable than using resizeObserver directly.
* @returns
*/
export const useDimensionsAlt1 = <T extends HTMLElement>() => {
const ref = useRef<T>(null);
const [size, setSize] = useState<DOMRect>();
useLayoutEffect(() => {
const element = ref.current;
if (element == null) return;
setSize(element.getBoundingClientRect());
}, [ref]);
useResizeObserver(ref, (entry) => setSize(entry.contentRect));
// Returning correctly with generics apparently requires type def here.
return [
ref,
size ?? { width: 0, height: 0 },
] as [
React.RefObject<T>,
DOMRect,
];
};
/**
* Based off the code demo for useResizeObserver.
* https://github.com/jaredLunde/react-hook/tree/master/packages/resize-observer
* @param target React Ref
* @returns
*/
export const useDimensionsAlt2 = <T extends HTMLElement>(target: React.RefObject<T>) => {
const [size, setSize] = useState<DOMRect>();
useLayoutEffect(() => {
setSize(target.current?.getBoundingClientRect());
}, [target]);
useResizeObserver(target, entry => setSize(entry.contentRect));
return size ?? { width: 0, height: 0, x: 0, y: 0 };
};